Fix ui jitter during remote server initialization#9342
Open
MaggieShan wants to merge 1 commit intomasterfrom
Open
Fix ui jitter during remote server initialization#9342MaggieShan wants to merge 1 commit intomasterfrom
MaggieShan wants to merge 1 commit intomasterfrom
Conversation
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR reroutes remote-server setup state updates through the Sessions model and updates the terminal view so the SSH remote-server loading footer can render during the binary-check phase.
Concerns
- The footer now treats
Checkingas an in-progress state, but several fallback paths abandon remote-server setup without clearing or terminalizing that stored state, so the input can stay hidden behind a staleChecking...footer while normal SSH bootstrap proceeds or hangs.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinyang372
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RemoteServerSetupStateChangedsuch thatsessionis able to handle and update itself, and the terminal view is only in charge of rerendering the footerTesting
https://www.loom.com/share/d4f157b4afd94f648f61ab1afbcee249
Agent Mode